Show distance in pixels to previous/next object in osu! hitobject inspector #28640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
previously approved these changes
Jun 27, 2024
|
Thanks to tests here, caught a pretty bad regression. @bdach please check you're okay with my changes. |
peppy
approved these changes
Jun 27, 2024
|
And here I was hoping to not have to spawn yet another virtual for once... Fair do's, changes look fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this bit of reddit feedback.
Implementation mostly follows stable except for the value displayed; stable would display the value relative to current slider velocity which seemed kinda unwieldy (and also annoying to implement wink, wink), so I'm not doing it. Can be re-added if users say they want it back.