Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix low pass filter sometimes not applied in dialog overlays #28652

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix low pass filter sometimes not applied in dialog overlays #28652

merged 1 commit into from
Jun 28, 2024

Conversation

smoogipoo
Copy link
Contributor

Fixes #28457

There are three issues resolved by this PR:

  • The issue (as above) where the filter sometimes doesn't get detached, is because of the two conditions in the callback.
  • The cutoff has a minimum value of 1Hz, otherwise the filter doesn't get applied at all. This is documented but not enforced by ManagedBass' BQFEffect class (which we're not using due to reasons), but I can't find the official docs. Failing to conform makes BASS not apply the filter. I've fixed this locally for now as I'm not yet sure how to do it more generally.
  • The filter wouldn't be applied when the dialog is first displayed, because of the missing BindValueChanged(..., true).

@peppy peppy self-requested a review June 28, 2024 06:37
@peppy peppy merged commit 04c09b5 into ppy:master Jun 28, 2024
13 of 17 checks passed
@Joehuu Joehuu mentioned this pull request Jul 1, 2024
Closed
@nekodex nekodex mentioned this pull request Jul 12, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
audio size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Low-pass filter sometimes gets stuck when exiting the editor
2 participants
@smoogipoo @peppy