Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor menus overflowing off screen #28765

Merged
merged 1 commit into from
Jul 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions osu.Game/Screens/Edit/Components/Menus/EditorMenuBar.cs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,10 @@ private void load(OverlayColourProvider colourProvider, TextureStore textures)
});
}

protected override Framework.Graphics.UserInterface.Menu CreateSubMenu() => new SubMenu();
protected override Framework.Graphics.UserInterface.Menu CreateSubMenu() => new SubMenu
{
MaxHeight = MaxHeight,
};

protected override DrawableMenuItem CreateDrawableMenuItem(MenuItem item) => new DrawableEditorBarMenuItem(item);

Expand Down Expand Up @@ -143,7 +146,10 @@ private void load(OverlayColourProvider colourProvider)
BackgroundColour = colourProvider.Background2;
}

protected override Framework.Graphics.UserInterface.Menu CreateSubMenu() => new SubMenu();
protected override Framework.Graphics.UserInterface.Menu CreateSubMenu() => new SubMenu
{
MaxHeight = MaxHeight,
};

protected override DrawableMenuItem CreateDrawableMenuItem(MenuItem item)
{
Expand Down
1 change: 1 addition & 0 deletions osu.Game/Screens/Edit/Editor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ private void load(OsuConfigManager config)
Anchor = Anchor.CentreLeft,
Origin = Anchor.CentreLeft,
RelativeSizeAxes = Axes.Both,
MaxHeight = 600,
Items = new[]
{
new MenuItem(CommonStrings.MenuBarFile)
Expand Down
Loading