Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editor player crashing with UR counter present in skin #28767

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix editor player crashing with UR counter present in skin #28767

merged 1 commit into from
Jul 8, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jul 8, 2024

Closes #28764.

smoogipoo
smoogipoo approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think this is good to pass in, I'd also expect a "nullable" property to be "nullable", so perhaps the extension is doing wrong in assuming it's not null.

@bdach
Copy link
Collaborator Author

bdach commented Jul 8, 2024 •
edited
Loading

If my memory isn't misleading me it's mostly nullable because of tests (no guarantee of an IGameplayClock above in hierarchy) which is unfortunate.

@smoogipoo smoogipoo merged commit 44ebec0 into ppy:master Jul 8, 2024
11 of 17 checks passed
@bdach bdach deleted the editor-test-play-ur-counter-crash branch July 8, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:editor size/XS type:reliability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nullable object must have a value occur in editor gameplay test
2 participants
@bdach @smoogipoo