Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setup screen controls that do nothing useful #28806

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Remove setup screen controls that do nothing useful #28806

merged 2 commits into from
Jul 10, 2024

Commits on Jul 10, 2024

  1. Remove setup screen controls that do nothing useful 

    Before I go with a hammer to redesign these, I want to remove stuff that
does nothing first.

Hard-breaks API to allow rulesets to specify an enumerable of custom
sections rather than two specific weird ones.

For specific rulesets:

- osu!:
  - Stack leniency slider merged into difficulty section.
- osu!taiko:
  - Approach rate and circle size sliders removed.
  - Colours section removed.
- osu!catch:
  - No functional changes.
- osu!mania:
  - Special style toggle merged into difficulty section.
  - Colours section removed.
    @bdach
    bdach committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c8a64c5 View commit details
    Browse the repository at this point in the history

  2. Just give in to silly code quality inspection

    @peppy
    peppy committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b58ba5f View commit details
    Browse the repository at this point in the history