Fix results screen fetching scores twice when scrolled to edge #29059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is not necessarily tied to daily challenge but it's something I noticed and it didn't feel well.
The fix here is, well, a schedule... Here's the order of how things happen:
ResultsScreen.Update
notices user is scrolled to beginning/end and fetches scores, blocking further fetches withlastFetchCompleted
fetchScoresCallback
is invoked, resettinglastFetchCompleted
ResultsScreen.Update
is called withlastFetchCompleted
state reset, therefore incorrectly fetching more scores.The fix is to schedule resetting
lastFetchCompleted
just one frame after adding the scores, so that the scroll container's state is updated before checking whether it's scrolled to beginning/end.Before:
CleanShot.2024-07-25.at.09.16.46.mp4
After:
CleanShot.2024-07-25.at.09.17.48.mp4