Fix insane transform allocations in new leaderboard display #29228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joehuu
approved these changes
Aug 1, 2024
smoogipoo
reviewed
Aug 2, 2024
| rankLabelOverlay.FadeIn(transition_duration, Easing.OutQuint); | ||
| else | ||
| rankLabelOverlay.FadeOut(transition_duration, Easing.OutQuint); | ||
| } | ||
|
|
||
| protected override bool OnInvalidate(Invalidation invalidation, InvalidationSource source) |
There was a problem hiding this comment.
For future reference, OnInvalidate should not reference any drawable values (like DrawWidth) anyway. I can't remember the exact reason for this but it was something along the lines of stack overflow due to recursive validation+invalidation, or stale values.
Edit: It did schedule it which would make things more safe, I misread it.
smoogipoo
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed on the live build. On master, there was enough going on here to cause severe stutters when scrolling the new leaderboard display (GC related).
osu.2024-08-01.at.07.39.59.mp4
I've modified the logic to much more correctly only perform any expensive operations when a change needs to be made. This not only improves performance butt also means the transforms aren't re-applied multiple times (causing delayed animations).
No need to include profiling results, video should give enough context.