Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix click sounds playing twice on OsuRearrangeableListItem #29244

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Fix click sounds playing twice on OsuRearrangeableListItem #29244

merged 3 commits into from
Aug 2, 2024

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Aug 2, 2024

Have checked all inherited classes.

Before:

Screen.Recording.2024-08-01.at.6.22.06.PM.mov

After:

Screen.Recording.2024-08-01.at.6.20.39.PM.mov

Side effect:

  • Collection text boxes don't have click sounds anymore (only hover sounds as hover isn't handled)
    • seems right as other textboxes (i.e. on login overlay, editor setup) don't have click (and hover) sounds, so the clicking is consistent

@Joehuu Joehuu added the audio label Aug 2, 2024
peppy
peppy approved these changes Aug 2, 2024
View reviewed changes
Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@peppy peppy merged commit 4c15485 into ppy:master Aug 2, 2024
9 checks passed
@Joehuu Joehuu deleted the fix-double-sounds-playlist-item branch August 2, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
audio size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joehuu @peppy