Fix daily challenge notification spam #29363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
added
the
next release
bdach
reviewed
Aug 12, 2024
| if (postNotification) | ||
| // We only want to notify the user if a new challenge recently went live. | ||
| if (room.StartDate.Value != null | ||
| && Math.Abs((DateTimeOffset.Now - room.StartDate.Value!.Value).TotalSeconds) < 600 |
There was a problem hiding this comment.
Before I go further - this is 10 minutes rather than 30, is it not? Is that ok?
There was a problem hiding this comment.
make a call, i think earthier is fine depending on perspective
bdach
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification will now only show:
Note that the second point here changes (simplifies) the behaviour by always showing, even in the game-started case. Previously it would only show if logging in. I think this aligns better.
Closes #29295.