Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview play button having incorrect click area #29438

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Aug 16, 2024

Scales the icon instead of the clickable PlayButton. Note the yellow hover/click area:

Before After
Screenshot 2024-08-15 at 10 53 33 PM Screenshot 2024-08-15 at 10 55 47 PM
Screenshot 2024-08-15 at 10 53 55 PM Screenshot 2024-08-15 at 10 55 09 PM

Uses const variables to know where 100 came from.

BeatmapCardNormal is visually the same, but other usages are slightly bigger because of the corner radius subtraction. It is because PlayButton.DrawWidth in BeatmapCardNormal is reduced by 10 by the parent's padding to accommodate for the corner radius on the right.

@smoogipoo smoogipoo merged commit 4ea7d9f into ppy:master Aug 16, 2024
9 of 13 checks passed
@Joehuu Joehuu deleted the fix-play-button-click-area branch August 16, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants