Make grid/distance snap binds T/Y respectively #29528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Just a few outwards notes to whoever needs to read them:
- As far as I'm aware this wasn't anyone "forcing" anything on anyone, rather than a plain oversight.
- Everything being rebindable is not guaranteed, and I'm not even convinced it's completely possible. Many contextual interactions require things like modifier keys to work and if we add full rebindability to everything, I can guarantee we're going to get reports from users who rebound their keys to the point of making the editor unusable by putting some action on Ctrl and thus breaking every single contextual interaction that requires control key pressed.
- If you're feeling like dunking on twitter, maybe take five minutes, take a deep breath, restrain your urge to dunk (I know, it's difficult), and find a better website to post feedback to. The osu! forums work, I read them. No extra accounts required.
|
Yep, aware this was an oversight. |
peppy
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://vxtwitter.com/captin01/status/1825388192343666920
It's probably best to invert these binds to not break user expectations until keybinds are implemented.