Allow copying beatmap link in song select carousel context menu #29537
Conversation
|
Just to list some other methods of doing the same thing in-game:
Note that the above only works while logged in, so that's probably another argument. |
Updated the description for better clarity |
|
Normally I'd reject this based on the premise that you can already do this in other ways as @Joehuu said, but the number of reactions on the OP is giving me a little pause. I'm not sure whether people didn't know you could do this already (albeit, admittedly, in a more roundabout manner), or just don't think that flow is good enough. |
|
I think this is handy to have here. Other methods are hidden or require more steps. |
|
That said, this PR is basically a "needs full rewrite". |
Joehuu
changed the title
| @@ -288,6 +296,9 @@ public MenuItem[] ContextMenuItems | |||
|
|
|||
| items.Add(new OsuMenuItem("Collections") { Items = collectionItems }); | |||
|
|
|||
| if (beatmapInfo.GetOnlineURL(api) is string url) | |||
| items.Add(new OsuMenuItem("Copy link", MenuItemType.Standard, () => clipboard.SetText(url))); | |||
There was a problem hiding this comment.
This doesn't have the OSD feedback like in ExternalLinkButton.
There was a problem hiding this comment.
May I ask about what the OSD stands for?
There was a problem hiding this comment.
You can google for an explanation. But please leave this alone, I'll fix it to keep things moving.
There was a problem hiding this comment.
OnScreenDisplay, but I dunno if it's better to copy the logic from ExternalLinkButton two more times, or add another method to OsuGame.
There was a problem hiding this comment.
Latter is more valid. I believe we will be using this in many more places going forward.
| @@ -288,6 +295,9 @@ public MenuItem[] ContextMenuItems | |||
|
|
|||
| items.Add(new OsuMenuItem("Collections") { Items = collectionItems }); | |||
|
|
|||
| if (beatmapInfo.GetOnlineURL(api) is string url) | |||
There was a problem hiding this comment.
No ruleset spec here? There is one on the beatmap set panels. And it does matter for stuff like converts.
There was a problem hiding this comment.
Yeah right, this was on my todo and I forgot to act on it.
Why
This could be very useful when playing on mobile, which player won't need to open their browser to just get the link. At the other side, desktop players can reduce the step of getting URLs, they don't need to jump to the browser and copy the link, instead just do it inside the game
Though the /np command can send the current beatmap to the chat, it doesn't make a use on if we want to share through the other app, like if we want to send it to discord.
Implementation
Add
Copy linkitem into bothDrawableCarouselBeatmapSetandDrawableCarouselBeatmapWhile
DrawableCarouselBeatmapSetCopy URL as$@"{api.WebsiteRootUrl}/beatmapsets/{beatmapSet.OnlineID}#{ruleset.ShortName}"andDrawableCarouselBeatmapcopy as$@"{api.WebsiteRootUrl}/beatmapsets/{beatmapSet.OnlineID}#{ruleset.ShortName}/{beatmapInfo.OnlineID}"