Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collections overflowing in the results screen #29742

Merged

Conversation

SchiavoAnto
Copy link
Contributor

@SchiavoAnto SchiavoAnto commented Sep 6, 2024

I took inspiration for this fix from the behaviour of the CollectionDropdownMenu in the song select screen.

The number I chose should be safe for maximum UI scaling too.

Copy link
Member

@Joehuu Joehuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@smoogipoo smoogipoo merged commit 6fb5c10 into ppy:master Sep 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When there are many collections, the "add to collection from results screen" function will overflow
3 participants