Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid updates (and update notifications) from appearing in more gameplay cases #30073

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Avoid updates (and update notifications) from appearing in more gameplay cases #30073

wants to merge 18 commits into from
+131 −78

Commits on Oct 1, 2024

  1. Adjust ILocalUserPlayInfo to expose whether gameplay is in a paused… 

    …/break state
    @peppy
    peppy committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ad3007e View commit details
    Browse the repository at this point in the history

  2. Make states better defined

    @peppy
    peppy committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3d54f4a View commit details
    Browse the repository at this point in the history

  3. Avoid updates and update notifications appearing in more gameplay cases

    @peppy
    peppy committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4b1c2c0 View commit details
    Browse the repository at this point in the history

  4. Fix local scores never importing due to new conditionals

    @peppy
    peppy committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8f0fedb View commit details
    Browse the repository at this point in the history

  5. Attempt to fix android class

    @peppy
    peppy committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7977ce8 View commit details
    Browse the repository at this point in the history

  6. Passing means NotPlaying

    @peppy
    peppy committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8dba4cf View commit details
    Browse the repository at this point in the history

  7. Rename enum to non-plural now that it won't conflict

    @peppy
    peppy committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8773c34 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Add failing test of importing failed replay in OsuGame flow 

    We had a test covering this but it wasn't within `OsuGame` so didn't
have full import blocking coverage (see
https://github.com/ppy/osu/blob/cbbe2f9dc04abb052a0d762aa798eba094fdd80c/osu.Game.Tests/Visual/Gameplay/TestScenePlayerLocalScoreImport.cs#L89-L88).
    @peppy
    peppy committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ecf144f View commit details
    Browse the repository at this point in the history

  2. Change failed states to be considered as NotPlaying

    @peppy
    peppy committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    24d6ea5 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Fix android build failure due to enum rename

    @peppy
    peppy committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a41c6dc View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary runOutsideOfGameplay call

    @peppy
    peppy committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    1f45b21 View commit details
    Browse the repository at this point in the history

  3. Add second call of runOutsideGameplay on update progress notification 

    At this point the update is already started in the background but I
guess we can still block the notification from interrupting the user.
    @peppy
    peppy committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    38ee824 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into updates-outside-of-gameplay-only-2

    @smoogipoo
    smoogipoo authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8dece70 View commit details
    Browse the repository at this point in the history

  5. Remove unrelated test

    @smoogipoo
    smoogipoo committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    19b586e View commit details
    Browse the repository at this point in the history

  6. Refactoring for correctness

    @smoogipoo
    smoogipoo committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6e659e1 View commit details
    Browse the repository at this point in the history

  7. Fix incorrect condition

    @smoogipoo
    smoogipoo committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    aee5f0e View commit details
    Browse the repository at this point in the history

  8. Return true while in gameplay 

    A `false` value marks the user as being on the latest release, and
notifies them as such when clicking the button in settings. In reality,
we don't know whether this is the case yet - we're just deferring the
check.

Somewhat minor change because the chance of a user manually going into
settings and clicking the button is very small.
    @smoogipoo
    smoogipoo committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    7cc6fe3 View commit details
    Browse the repository at this point in the history

  9. Remove unused parameter

    @smoogipoo
    smoogipoo committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    c3f2c82 View commit details
    Browse the repository at this point in the history