Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move setup screen background preview to appropriate form control #30109

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Move setup screen background preview to appropriate form control #30109

merged 1 commit into from
Oct 4, 2024
+43 −41

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Oct 4, 2024

See https://discord.com/channels/188630481301012481/188630652340404224/1291361342971707463.

2024-10-04.11-11-52.mp4

I'm not super happy with the background colour now clashing with the menu bar, but...

  • I can't make the menu bar lighter without either having the menu items have the same colour as the background, or running out of BackgroundX shades
  • Making the setup screen background darker causes disabled textboxes to clash with the background.

@peppy peppy self-requested a review October 4, 2024 09:21
peppy
peppy approved these changes Oct 4, 2024
View reviewed changes
Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. We can deal with the menu background later when we have designer throughput available.

@peppy peppy merged commit 24227b4 into ppy:master Oct 4, 2024
8 of 9 checks passed
@bdach bdach deleted the editor/setup-screen-better-background-selector branch October 4, 2024 10:13
@Joehuu Joehuu mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
area:editor size/M type:cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdach @peppy