Fix stage line alignment in mania not matching stable #30590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
commented
Nov 12, 2024
| @@ -54,7 +54,8 @@ private void load(ISkinSource skin, StageDefinition stageDefinition) | |||
| }, | |||
| columnBackgrounds = new ColumnFlow<Drawable>(stageDefinition) | |||
| { | |||
| RelativeSizeAxes = Axes.Y | |||
| RelativeSizeAxes = Axes.Y, | |||
| Masking = false, | |||
There was a problem hiding this comment.
Masking is disabled here because the right line of the last column exceeds the flow's bounds (correctly so).
| @@ -126,8 +127,8 @@ private void load(ISkinSource skin) | |||
| }, | |||
| new Container | |||
| { | |||
| X = isLastColumn ? -0.16f : 0, | |||
There was a problem hiding this comment.
This part also comes from stable (x1.6), wouldn't hurt to include it. See stable reference.
smoogipoo
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
I guess this comes at the caveat that some lines lose a bit of thickness, but it matches stable anyway.