Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale down beatmap cards #30748

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Scale down beatmap cards #30748

merged 3 commits into from
Nov 25, 2024

Conversation

stanriders
Copy link
Member

@stanriders stanriders commented Nov 18, 2024

Resolves #30649

Before-after:
Extra:
image
image

Normal:
image
image

@bdach
Copy link
Collaborator

bdach commented Nov 18, 2024

At this point I question these local scale overrides. "Just" change the metrics of the cards to reflect this everywhere?

@peppy
Copy link
Member

peppy commented Nov 18, 2024

Have you checked the remaining usage of this in a list view (SpotlightsLayout)? It sounds like this should be applied there too.. at which point I'd maybe consider changing the base specs and adjusting the cases that don't want the smaller scale to increase it.

@stanriders
Copy link
Member Author

Fair enough, I'll scale the card itself

@stanriders stanriders changed the title Scale down beatmap cards in profile overlay Scale down beatmap cards Nov 18, 2024
@stanriders
Copy link
Member Author

I didn't scale beatmap badges as they've seem to be correctly sized for the smaller card already, and didn't change the nano-sized cards at all since they seem to be fine too

@peppy
Copy link
Member

peppy commented Nov 18, 2024

Keep in mind when reviewing this that some usages are now smaller than they used to be (one example is the solo spectator screen).

@stanriders
Copy link
Member Author

I intentionally didn't scale any of the usages up to the previous size to make it consistent across all card usages and it didn't look wrong to me

bdach
bdach previously requested changes Nov 19, 2024
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you got everything. In particular the various badges on the cards seem to have grown in size, relatively speaking, and so has the difficulty bar display:

master this PR
osu_2024-11-19_12-01-48 osu_2024-11-19_12-02-18

@stanriders
Copy link
Member Author

I don't think you got everything. In particular the various badges on the cards seem to have grown in size, relatively speaking, and so has the difficulty bar display:

As I've said, I didn't change badges because they looked too small for the original size already, as for the other differences I think that's probably because I didn't scale elements exactly 0.8x, but to the closest integer size (so things that were 12 became 10 instead of 9.6 and such)
I'll recheck just in case though

@peppy
Copy link
Member

peppy commented Nov 20, 2024

I can agree that the larger badges look better. Previously they look too small.

@bdach
Copy link
Collaborator

bdach commented Nov 20, 2024

As long as you also accept the tradeoff that less of artist/title may become visible as a result...

@peppy peppy self-requested a review November 22, 2024 09:33
@bdach bdach dismissed their stale review November 22, 2024 10:03

i guess irrelevant

@peppy peppy merged commit 9ca17f9 into ppy:master Nov 25, 2024
9 of 10 checks passed
@stanriders stanriders deleted the scale-profile-beatmaps branch November 25, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants