Add player settings to multi spectator screen #30749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we're going to do this, please make it do the settings expand when moving the cursor near the right of the screen, or when hovering the cog. |
|
Now expands and contracts from hovering the right side of the screen: 2024-11-23.01-06-42.mp4 |
|
@Sheppsu sorry to kind of take over and rewrite this to some extent, but I had some major issues with the structure, especially when trying to make use of this in more places than you originally envisaged. See what you think of my changes, I've committed them. |
|
Makes sense. Changes look good 👍 |
peppy
previously approved these changes
Nov 28, 2024
|
Requesting a second opinion as I wrote a lot of this now. |
|
Are the settings supposed to show during normal gameplay...? 2024-11-28.13-37-58.mp4I feel like that's not going to go over well with users... |
|
Nope, that looks like a regression from my refactors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating this for #29709 so the analysis settings have a place to go, but it's also nice to have the player settings on the multi spectator screen.
Looks like this:
2024-11-18.03-56-06.mp4