Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strong drum rolls being counted for double the combo in legacy scoring attributes #30917

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Nov 29, 2024

This is the root cause of a multi-system failure that ultimately causes ppy/osu-web#11697. It appears that my theory I described in that issue is correct, although this root failure is a little more specific than I initially suspected - only maps with strong drum rolls are affected, rather than maps with any drum rolls at all.

Around 6k beatmaps in total are affected by this. List available here: https://gist.github.com/bdach/a719beed292ef0632dc8d002eb9b274c

Caution

Intended for @peppy first and foremost:
This change affects total score for all scores imported from stable which were set on the affected beatmaps in the new database tables. Therefore, this pull should be followed up with:

  • recomputation of scoring attributes for osu!taiko,
  • verification of all imported taiko scores via osu-queue-score-statistics (I'd ask to hold with doing that until verification can correct maximum_statistics, which also are affected by this failure and cause further failures down the stack, as described in the issue thread - working on that as I write this see Add capability to verify maximum statistics of scores osu-queue-score-statistics#306).

I ran a sheet locally and it looks as I'd expect it to, but will run one through the workflow here for transparency.

run all ranked
run from 90634 non-ranked

@bdach
Copy link
Collaborator Author

bdach commented Nov 29, 2024

!diffcalc
RULESET=taiko
GENERATORS=score

Copy link

Target: #30917
Spreadsheet: https://docs.google.com/spreadsheets/d/1uEANHvZdqRZ946JdRhlwfQ8v98H8GCoz6fI2PVOzVY8/edit

@peppy peppy merged commit ce4aac4 into ppy:master Dec 3, 2024
8 of 10 checks passed
@peppy peppy self-requested a review December 3, 2024 04:09
@bdach bdach deleted the fix-incorrect-taiko-legacy-combo branch December 3, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants