fix: correctly find npm on Python 3.12 (win)

[agoose77]

On Python 3.12.0, shutil.which finds the Bash npm shell script rather than npm.CMD when the system is Windows. This PR effectively looks for PATHEXT-suffixed binaries and takes them in preference.

Fixes #46

[agoose77]

@pradyunsg not sure what your notification setup is, so I'm manually pinging you. Apologies if you're already tracking this.

[pradyunsg]

Ah, so it's python/cpython#109590.

[agoose77]

@pradyunsg is there anything you need me to do here? I'm under the impression you'll want to think about this, but let me know if there's any further work to be done on my part!

[pradyunsg]

No, I think I've got everything here from you -- thanks for filing this, it's genuinely appreciated! It would've taken me quite a while to realise this was a CPython bug without a prompt from this PR and this fix.

I have to spend some time context switching back into this project sometime in the next few weeks to catch up on what's borked and all that -- I've got a lot of life happening over the past few weeks for me and being a volunteer maintainer on OSS stuff comes lower in the hierarchy of things for me. :)

[agoose77]

I have to spend some time context switching back into this project sometime in the next few weeks to catch up on what's borked and all that -- I've got a lot of life happening over the past few weeks for me and being a volunteer maintainer on OSS stuff comes lower in the hierarchy of things for me. :)

Totally get it — good luck with IRL! We'll move forward over at EB with working wheels, and pick up the sdist side of things when we next circle back.

Equally, I'm happy to take on some maintainership here, so let me know if you're interested. My outgoing role is on scikit-hep/awkward, and I'm also involved in the EB project (e.g. executablebooks/jupyterlab-myst).

[agoose77]

@pradyunsg do you perhaps have any more time to take a look at this PR? Let me know if there's more I can/should do here.