Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo consistency #639

Open
wants to merge 43 commits into
base: develop
Choose a base branch
from
Open

Repo consistency #639

wants to merge 43 commits into from

Conversation

fritzbrand
Copy link
Contributor

@fritzbrand fritzbrand commented Oct 22, 2024 •
edited
Loading

This PR is for the repo consistency work done on this repo.

The main goal is getting all repos to use poetry for package management, and ruff for linting.

@fritzbrand
Need to merge develop back in
9126a9f
@fritzbrand
Merge branch 'develop' into repo-consistency
d47888e
@fritzbrand
Added direct git install for iso639
6f9842a
@fritzbrand
Perparing to remove pip
9996a04
@fritzbrand
Unpinned versions
a45b777
@fritzbrand
Pinned specific 'rapidpro-python' version
904614d
@fritzbrand
Added blanket ignores until ruff throws no errors
5a88fc4
@fritzbrand
Redefinition of unused and ruff format
a9f57f1
@fritzbrand
Use 'enumerate()' for index variable 'total' in 'for' loop
346e40f
@fritzbrand
Use ternary operator instead of 'if'-'else'-block
a7c53c2
@fritzbrand
Return the condition 'label in labels' directly
3d470a6
@fritzbrand
'typing.Text' is deprecated, use 'str'
95a413f
@fritzbrand
Unnecessary 'map' usage (rewrite using a generator expression)
e4fd7bd
@fritzbrand
Do not use mutable data structures for argument defaults
a4e5d64
@fritzbrand
Found useless expression. Either assign it to a variable or remove it.
570704f
@fritzbrand
Possible hardcoded password assigned
d982515
@fritzbrand
Unnecessary imports for target Python version
721c825
@fritzbrand
Within an 'except' clause, raise exceptions with 'raise ... from err'…
462ce1b 
… or 'raise ... from None'
@fritzbrand
Standard pseudo-random generators are not suitable for cryptographic …
3fb00c5 
…purposes
@fritzbrand
Use 'super()' instead of 'super(__class__, self)'
fed49a6
@fritzbrand
Use format specifiers instead of percent format
ac1974f
@fritzbrand
'try'-'except'-'continue' detected, consider logging the exception
61b890a
@fritzbrand
Use 'contextlib.suppress(Exception)' instead of 'try'-'except'-'pass'
13ec3dd
@fritzbrand
Use a single 'if' statement instead of nested 'if' statements
340904e
@fritzbrand
Use 'is' and 'is not' for type comparisons, or 'isinstance()' for isi…
3072035 
…nstance checks
@fritzbrand
Use 'return any(post in group[name].lower() for group in contact[grou…
7bd8a0f 
…ps])' instead of 'for' loop
@fritzbrand
'try'-'except'-'pass' detected, consider logging the exception
1f1eb00
@fritzbrand
Possible hardcoded password assigned to argument
143e247
@fritzbrand
Loop control variable 'status_code' not used within loop body
e4e40d3
@fritzbrand
Class 'Template' inherits from 'object'
4f8c9a9
@fritzbrand fritzbrand marked this pull request as ready for review October 23, 2024 05:17
@fritzbrand fritzbrand requested a review from erikh360 October 23, 2024 05:17
erikh360
erikh360 reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@erikh360 erikh360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just the two small changes

eventstore/tests/test_views.py Outdated Show resolved Hide resolved
eventstore/tests/test_whatsapp_actions.py Outdated Show resolved Hide resolved
jerith
jerith reviewed Oct 23, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
eventstore/tests/test_views.py Outdated
)
(self.assertEqual(messages.id, "9e12d04c-af25-40b6-aa4f-57c72e8e3f91"),)
(self.assertEqual(messages.type, "image"),)
(self.assertEqual(messages.message_direction, Message.INBOUND),)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like ruff has helpfully turned a bunch of accidental trailing commas into explicit tuples. Perhaps we should remove the commas instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are more of these -- mostly multiline ones. Any line that starts (self.assert... or the multiline equivalent with the ( on the line above can be de-tupled.

eventstore/tests/test_whatsapp_actions.py Outdated Show resolved Hide resolved
scripts/growgreat_extract/msisdn_from_details.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerith jerith jerith left review comments

@erikh360 erikh360 erikh360 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fritzbrand @jerith @erikh360