Add client stream publisher #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudigiesler
reviewed
Nov 21, 2024
| @@ -98,13 +99,17 @@ def __init__( | |||
| self.buffer = bytearray() | |||
| self.responses: dict[int, MemorySendChannel] = {} | |||
| self.encoder = PDUEncoder() | |||
| self.pdu_send_channel: MemorySendChannel | |||
| self.pdu_receive_channel: MemoryReceiveChannel | |||
There was a problem hiding this comment.
Is this typing information necessary? I would've thought that open_memory_channel[PDU](0) would be typed, so that we don't need to specify the type here
| return None | ||
|
|
||
| send_channel, receive_channel = open_memory_channel[PDU](0) | ||
| send_channel: MemorySendChannel | ||
| receive_channel: MemoryReceiveChannel |
There was a problem hiding this comment.
Same question here for changing this typing
There was a problem hiding this comment.
I initially didn't have it, ruff complained about type annotation for these.
There was a problem hiding this comment.
This class (and a few others, I expect) could really benefit from using attrs to manage all the various fields. I think let's leave the type annotations as-is here and switch to attrs in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
added a stream publisher to ensure that one pdu is sent at a time
Checklist