Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WireGuard PrivateKey/PresharedKey rule #104

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

gemesa
Copy link
Contributor

@gemesa gemesa commented Dec 15, 2023

This is a rule I regularly use to look for WireGuard .conf files (specifically private and preshared WG keys). Maybe it makes sense to add it to the defaults. I generated the 2 keys in the example myself just for this purpose.

Copy link
Collaborator

@bradlarsen bradlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gemesa! This looks really good. This will allow Nosey Parker to detect more secrets with precision.

Would you please split this new WireGuard PrivateKey/PresharedKey rule into two new rules? They are conceptually different things, even if they have the same format. WireGuard Private Key and WireGuard Preshared Key are good names for them.

@gemesa
Copy link
Contributor Author

gemesa commented Dec 15, 2023

Thank you @gemesa! This looks really good. This will allow Nosey Parker to detect more secrets with precision.

Would you please split this new WireGuard PrivateKey/PresharedKey rule into two new rules? They are conceptually different things, even if they have the same format. WireGuard Private Key and WireGuard Preshared Key are good names for them.

I split them and fixed the review findings, please check it out.

@bradlarsen bradlarsen merged commit 4ab10c4 into praetorian-inc:main Dec 16, 2023
8 checks passed
@bradlarsen
Copy link
Collaborator

Thank you for your contribution, @gemesa!

@gemesa gemesa deleted the wireguard-rule branch December 16, 2023 05:56
@bradlarsen bradlarsen added detection Related to rules or detection of sensitive information enhancement New feature or request labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detection Related to rules or detection of sensitive information enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants