Rework input enumeration #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradlarsen
added
enhancement
The newer vectorscan-rs release implements several additional traits for the types it exposes, including Clone. In Nosey Parker scanning, each time a scanning thread is spawned, a matching context needs to be created. With the changes here, a single initial context is cloned rather than a new one being reinitialized from scratch. This saves several CPU seconds on some larger scanner inputs. (What would be even better is if each scanner thread were long-lived and initialized exactly once. But this is difficult to control using Rayon.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inputs are now enumerated incrementally as scanning proceeds rather than done in an initial batch step. This reduces peak memory use and CPU time 10-20%, particularly in environments with slow I/O. A consequence of this change is that the total amount of data to scan is not known until it has actually been scanned, and so the scanning progress bar no longer shows a completion percentage.