Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the signature provider functional #19

Merged
merged 2 commits into from
Aug 1, 2016

Conversation

RSDuck
Copy link
Contributor

@RSDuck RSDuck commented Jul 21, 2016

As far as I tested it, it worked including that it shows which parameter is currently selected and that when a procedure is called with the object.procedure(object goes into first parameter) syntax it automaticly jumps to the second parameter.
In some rare occasions it is a little bit wonky because of NimSuggest(for example when there is already written if == 0: and you want to write the part before the ==), but in most cases it works perfectly.

Also as a small addition I added " as brackets, so when one is typed the other gets inserted automaticly and added to the hover provider that it shows also the type of a symbol.

@oderwat
Copy link
Contributor

oderwat commented Jul 21, 2016

Cool!

But I noticed that if you have multiple signature matches (I have 4 in my example here http://www.giphy.com/gifs/l46CCqJCiUvwDHkMU) and you move lets say to the second one, it jumps back to the first one when you start typing anything. I guess it updates with a new nimsuggest result. But maybe one could leave it on the same selection until the results from nimsuggest differ. Maybe even stay on the selected one as long as it is part of the results from nimsuggest.

@RSDuck
Copy link
Contributor Author

RSDuck commented Jul 25, 2016

I looked up, there is no way to get the currently selected signature. So it isn't possible to do something like that.

@kosz78 kosz78 merged commit 6eafbaa into pragmagic:master Aug 1, 2016
@RSDuck RSDuck deleted the signature-provider branch August 1, 2016 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants