Fix extension stuck on building on windows platform #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omeshp
force-pushed
the
users/omeshp/FixForWindows
branch
from
c82977c
to
19ca9d6
Compare
|
@prashaantt Does these changes look good? spawning npm fails on windows as suggested in issue nodejs/node#3675 we should be using npm.cmd. |
|
Thanks a ton for this @omeshp! I think I'd arrived at a similar solution when I tried to fix it, but didn't know it was a legit bug in Node itself and so I couldn't be sure. I'll take a look at the linked bug and get hang of a Windows machine (hopefully this week itself) to test out your code and merge. |
|
@omeshp I ended up handling this slightly differently. Thanks for your PR regardless! |
|
@prashaantt ok cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.