Removing unnecessary call to setMeta

prashantrewar · Feb 7, 2022 · 13b8b42 · 13b8b42
1 parent 5038d99
commit 13b8b42
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/pkg/kapp/app/recorded_app.go b/pkg/kapp/app/recorded_app.go
@@ -361,16 +361,12 @@ func (a *RecordedApp) update(doFunc func(*Meta)) error {
 
 	change.Data = meta.AsData()
 
-	updatedMeta, err := a.coreClient.CoreV1().ConfigMaps(a.nsName).Update(context.TODO(), change, metav1.UpdateOptions{})
+	_, err = a.coreClient.CoreV1().ConfigMaps(a.nsName).Update(context.TODO(), change, metav1.UpdateOptions{})
 	if err != nil {
 		return fmt.Errorf("Updating app: %s", err)
 	}
 
-	// Update memoized meta
-	_, err = a.setMeta(*updatedMeta)
-	if err != nil {
-		return err
-	}
+	a.memoizedMeta = &meta
 
 	return nil
 }