Skip to content

Commit

Permalink
Fix regression from bumping cobrautil
Browse files Browse the repository at this point in the history
* Missed scoping the DisallowingExtraArgs to leaf commands, which
  was causing the top level kapp to no longer output the help text
  when an unkown command was used

Authored-by: Eli Wrenn <ewrenn@pivotal.io>
  • Loading branch information
ewrenn8 committed Jan 26, 2021
1 parent c39be3a commit 28dfdd0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/kapp/cmd/kapp.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ func NewKappCmd(o *KappOptions, flagsFactory cmdcore.FlagsFactory) *cobra.Comman

// Last one runs first
cobrautil.VisitCommands(cmd, finishDebugLog, cobrautil.ReconfigureCmdWithSubcmd,
cobrautil.DisallowExtraArgs, configureUIAndLogger, cobrautil.WrapRunEForCmd(cobrautil.ResolveFlagsForCmd))
cobrautil.ReconfigureLeafCmds(cobrautil.DisallowExtraArgs), configureUIAndLogger, cobrautil.WrapRunEForCmd(cobrautil.ResolveFlagsForCmd))

return cmd
}
Expand Down

0 comments on commit 28dfdd0

Please sign in to comment.