Skip to content

Commit

Permalink
make sure istio/knative examples are exactly same compared to upstream
Browse files Browse the repository at this point in the history
  • Loading branch information
cppforlife committed Mar 19, 2019
1 parent 0cc272e commit 39339f9
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 10 deletions.
4 changes: 2 additions & 2 deletions examples/knative-v0.2.1/release-no-mon.yml
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ spec:
apiVersion: v1
kind: Service
metadata:
# TODO annotations: null
annotations: null
labels:
app: knative-ingressgateway
chart: gateways-1.0.1
Expand Down Expand Up @@ -1352,7 +1352,7 @@ metadata:
---
apiVersion: v1
data:
istio.sidecar.includeOutboundIPRanges: '10.20.4.167/14,10.128.0.6/14'
istio.sidecar.includeOutboundIPRanges: '*'
kind: ConfigMap
metadata:
name: config-network
Expand Down
14 changes: 7 additions & 7 deletions examples/knative-v0.2.1/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1352,7 +1352,7 @@ metadata:
---
apiVersion: v1
data:
istio.sidecar.includeOutboundIPRanges: '10.20.4.167/14,10.128.0.6/14'
istio.sidecar.includeOutboundIPRanges: '*'
kind: ConfigMap
metadata:
name: config-network
Expand Down Expand Up @@ -1535,7 +1535,7 @@ metadata:
app: elasticsearch-logging
kubernetes.io/cluster-service: "true"
name: elasticsearch-logging
# namespace: knative-monitoring TODO fix me
namespace: knative-monitoring
roleRef:
apiGroup: ""
kind: ClusterRole
Expand Down Expand Up @@ -7359,7 +7359,7 @@ apiVersion: rbac.authorization.k8s.io/v1beta1
kind: ClusterRole
metadata:
name: kube-state-metrics
# namespace: knative-monitoring TODO fix me
namespace: knative-monitoring
rules:
- apiGroups:
- ""
Expand Down Expand Up @@ -7427,7 +7427,7 @@ apiVersion: rbac.authorization.k8s.io/v1beta1
kind: ClusterRoleBinding
metadata:
name: kube-state-metrics
# namespace: knative-monitoring TODO fix me
namespace: knative-monitoring
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
Expand Down Expand Up @@ -13810,7 +13810,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: node-exporter
# namespace: knative-monitoring TODO fix me
namespace: knative-monitoring
rules:
- apiGroups:
- authentication.k8s.io
Expand All @@ -13829,7 +13829,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: node-exporter
# namespace: knative-monitoring TODO fix me
namespace: knative-monitoring
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
Expand Down Expand Up @@ -16960,7 +16960,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: prometheus-system
# namespace: knative-monitoring TODO fix me
namespace: knative-monitoring
rules:
- apiGroups:
- ""
Expand Down
8 changes: 7 additions & 1 deletion examples/knative-v0.2.3/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1535,6 +1535,7 @@ metadata:
app: elasticsearch-logging
kubernetes.io/cluster-service: "true"
name: elasticsearch-logging
namespace: knative-monitoring
roleRef:
apiGroup: ""
kind: ClusterRole
Expand All @@ -1556,7 +1557,7 @@ metadata:
name: elasticsearch-logging
namespace: knative-monitoring
spec:
replicas: 3
replicas: 2
selector:
matchLabels:
app: elasticsearch-logging
Expand Down Expand Up @@ -7358,6 +7359,7 @@ apiVersion: rbac.authorization.k8s.io/v1beta1
kind: ClusterRole
metadata:
name: kube-state-metrics
namespace: knative-monitoring
rules:
- apiGroups:
- ""
Expand Down Expand Up @@ -7425,6 +7427,7 @@ apiVersion: rbac.authorization.k8s.io/v1beta1
kind: ClusterRoleBinding
metadata:
name: kube-state-metrics
namespace: knative-monitoring
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
Expand Down Expand Up @@ -13807,6 +13810,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: node-exporter
namespace: knative-monitoring
rules:
- apiGroups:
- authentication.k8s.io
Expand All @@ -13825,6 +13829,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: node-exporter
namespace: knative-monitoring
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
Expand Down Expand Up @@ -16955,6 +16960,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: prometheus-system
namespace: knative-monitoring
rules:
- apiGroups:
- ""
Expand Down
File renamed without changes.

0 comments on commit 39339f9

Please sign in to comment.