clarify purpose of ./hack/build-values-get-kapp-io.yml

prashantrewar · Jun 3, 2019 · 6f6c708 · 6f6c708
1 parent 290ac96
commit 6f6c708
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -41,7 +41,9 @@ Grab prebuilt binaries from the [Releases page](https://github.com/k14s/kapp/rel
 export KAPP_E2E_NAMESPACE=kapp-test
 ./hack/test-all.sh
 
-BUILD_VALUES=./hack/build-values-get-kapp-io.yml ./hack/build.sh # includes goog analytics
+# include goog analytics in 'kapp website' command for https://get-kapp.io
+# (goog analytics is _not_ included in release binaries)
+BUILD_VALUES=./hack/build-values-get-kapp-io.yml ./hack/build.sh
 ```
 
 `build.sh` depends on [ytt](https://github.com/k14s/ytt).
diff --git a/hack/build-binaries.sh b/hack/build-binaries.sh
@@ -2,6 +2,8 @@
 
 set -e -x -u
 
+BUILD_VALUES= ./hack/build.sh
+
 GOOS=darwin GOARCH=amd64 go build -o kapp-darwin-amd64 ./cmd/kapp/...
 GOOS=linux GOARCH=amd64 go build -o kapp-linux-amd64 ./cmd/kapp/...
 GOOS=windows GOARCH=amd64 go build -o kapp-windows-amd64.exe ./cmd/kapp/...