Comparing and returning slices more appropriately

prashantrewar · Feb 9, 2022 · eeeceb3 · eeeceb3
1 parent eff69cf
commit eeeceb3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/kapp/cmd/app/deploy.go b/pkg/kapp/cmd/app/deploy.go
@@ -249,8 +249,8 @@ func (o *DeployOptions) newAndUsedGKs(newGKs []schema.GroupKind, app ctlapp.App)
 	if err != nil {
 		return nil, err
 	}
-	if usedGKs == nil && lastChange != nil {
-		return nil, nil
+	if len(usedGKs) == 0 && lastChange != nil {
+		return []schema.GroupKind{}, nil
 	}
 
 	for _, gk := range usedGKs {

diff --git a/pkg/kapp/resources/identified_resources_list.go b/pkg/kapp/resources/identified_resources_list.go
@@ -37,7 +37,7 @@ func (r IdentifiedResources) List(labelSelector labels.Selector, resRefs []Resou
 		schema.GroupVersionResource{Version: "v1", Resource: "componentstatuses"},
 	})
 
-	if opts.GKsScope != nil {
+	if len(opts.GKsScope) > 0 {
 		resTypes = MatchingAnyGK(resTypes, opts.GKsScope)
 	}