Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Protobuf Support #723

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

Welkin-Y
Copy link
Contributor

@Welkin-Y Welkin-Y commented Sep 28, 2023

Change log description

Purpose of the change
Add Protobuf Support of Schema registry

What the code does
Add Protobuf Support of Schema registry and corresponding test case

How to verify it
Run test will show pass

@crazyzhou crazyzhou changed the base branch from master to feature-protobuf-catalog October 18, 2023 09:59
Copy link
Contributor

@crazyzhou crazyzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good, will follow up on the tests, docs and use case next

@crazyzhou crazyzhou merged commit 02fce28 into pravega:feature-protobuf-catalog Oct 18, 2023
1 of 3 checks passed
Welkin-Y added a commit to Welkin-Y/Pravega-flink-connectors that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants