Skip to content

Commit

Permalink
Add matrix gem to dependencies
Browse files Browse the repository at this point in the history 
matrix has been a gem since 2.5 but was removed from the default set in
Ruby 3.1.
  • Loading branch information
@pointlessone
pointlessone committed May 31, 2021
1 parent db4544a commit 3658d51
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions prawn.gemspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ Gem::Specification.new do |spec|
]
spec.licenses = %w[PRAWN GPL-2.0 GPL-3.0]

spec.add_dependency('matrix', '~> 0.4')
spec.add_dependency('pdf-core', '~> 0.9.0')
spec.add_dependency('ttfunk', '~> 1.7')

Expand Down

3 comments on commit 3658d51

@mathieujobin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't in prawn 2.4.0, maybe we should release a 2.4.1 ?

@arockwell
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is a really small thing, but I would vote yes for 2.4.1. I’m working on moving an older project to ruby 3.2, and encountered this issue.

However, I will admit the workaround is straightforward (just manually include the matrix gem).

@jgarber623
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not accounted for in the CHANGELOG, Releases (for which there isn't a v2.5.0), or on the v2.5.0 tag, but the matrix gem is now specified in v2.5.0's metadata file. So, at long last, this should be resolved. 🥳

Please sign in to comment.