-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
* Skip drawing the table cells if they contain only the header. #717
Conversation
donv
commented
Apr 28, 2014
- Fixes Table header should not be rendered if the next row does not fit on the current page. #707
I see the travis specs fail, but none of the failures are related to this change. |
@donv: Those look like Rubocop related issues. @packetmonkey: At this stage I would really like to avoid failing the build for Rubocop-related issues we haven't already cleared out of the codebase. Can you investigate? |
Interesting it looks like the failures are coming from Rubocop but when I merged that code I disabled all the cops that caused any failures and are slowly turning them on in PR's that enable the cop and fix any problems. When I clone your branch and run the tests I don't see the failures on my end. The I'll lock the gemspec to the specific version of rubocop I tested against, then you should be able to rebase your PR which should make the tests pass. I'll update again in a few minutes when I have that sorted out for you. |
There! It should be OK now. |
OK to merge? |
I think so, you can merge it! Please make sure to at least put a placeholder link back to this pull request in the MasterChangelog |
* Skip drawing the table cells if they contain only the header.
Done. Are we using milestones? Should I file this against the next release? 1.1? |