Added support for transparency in indexed PNG images #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! In order to get the test suite passing, do we need to just remove the spec that was ensuring we raised an exception for palleted PNG files? Also I think you left a puts in the specs, we should remove that before merging. |
pointlessone
force-pushed
the
alpha-palette
branch
from
ecf0ba3 to
823df34
Compare
|
@packetmonkey My bad. Fixed specs, removed |
pointlessone
force-pushed
the
alpha-palette
branch
from
646f274 to
ba8cbc1
Compare
|
this fixes an issue i've been seeing on my end. when can we expect to see this merged? |
|
This would fix and issue I have. When can this be merged? |
packetmonkey
added a commit
that referenced
this pull request
Dec 16, 2015
Added support for transparency in indexed PNG images
|
@cheba Strangely master is now broken in Travis, I re-ran the build and it looks still broken after merging this and it bundles locally correctly. Can you check this out to see if we broke something with this PR? |
This was referenced Dec 22, 2015
Closed
hidakatsuya
added a commit
to thinreports/thinreports-generator
that referenced
this pull request
Apr 22, 2017
But PNG images with indexed transparency has been supported by Prawn: prawnpdf/prawn#920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #783
Here's how
palette-8.png(from the supplied test case) looks like in the resulting document.