Formatted text has wrong leading with one line paragraphs #922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's wrong: If you are indenting a paragraph, but have only one line to print, it will be printed by
draw_indented_formatted_line
completely. Thus,remaining_text
is empty, but Prawn tries to print it anyway. The problem is thatfill_formatted_text_box
is still changing they
value of the document if you specify leading:box.height
andbox.line_gap
are zero for an empty remaining text, but box.leading is not. This causes a wrong leading in your text if you have single line paragraphs.Example:
Space between the first paragraphs is too large. It should have the same leading as between the second and third paragraph.