-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua API improvements + direct UEVR integration #255
Conversation
lua-api/lib/src/ScriptContext.cpp
Outdated
const auto desc = c->find_property(name.c_str()); | ||
|
||
if (desc == nullptr) { | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these early returns log something to help the script developer? If the property / class isn't found (typo, wrong path, whatever) then the failing set_property call might go unnoticed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I can add a throw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Important additions
<config folder>/scripts/*.lua
Lua API improvements
Properties can now be accessed and set
UObject*
elements)TODO:
StructProperty (vectors etc),ClassProperty,ByteProperty,EnumPropertyFunctions can now be called on objects
ex:
TODO:
StructProperty (vectors etc), Array parameters, out parameters,ByteProperty,EnumProperty