Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .k (kcl file type) to extensions.py #421

Closed
wants to merge 1 commit into from
Closed

add .k (kcl file type) to extensions.py #421

wants to merge 1 commit into from

Conversation

prahaladramji
Copy link

@prahaladramji prahaladramji commented Oct 18, 2023

This PR add .k file type into extensions.py
This extension is used by files for kcl.

@prahaladramji prahaladramji changed the title add .k (kcl-lang file type) to extensions.py add .k (kcl file type) to extensions.py Oct 18, 2023
@asottile
Copy link
Member

file extensions must be unambiguous. searching this file extension gives me many other things (and curiosly none of them are kcl)

@asottile asottile closed this Oct 18, 2023
@prahaladramji
Copy link
Author

prahaladramji commented Oct 18, 2023

@asottile what is the criteria for this? If it must be unambiguous then i'm guessing it'd be difficult with a single character extension. :).

Would it have been acceptable if i replaced the term from kcl to kcl-lang, which a google search provides exactly the expected result.

The kcl project was recently accepted into the cloud native foundation project.
https://www.cncf.io/projects/kcl/

@asottile
Copy link
Member

I searched ".k extension" if that's not unambiguous I can't accept it

@asottile
Copy link
Member

it's not my fault the kcl project made a poor decision on their file extension

@prahaladramji
Copy link
Author

fair enough, thanks for info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants