-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify rust-toolchain files as rust-toolchain #459
Conversation
Introduce dedicated types for rust-toolchain and rust-toolchain.toml files. Cargo linting rules can change with the rust version, so it's helpful to match against the rust-toolchain files as a trigger for Rust linting hooks.
same feedback as your other PR: #460 (comment) |
Yes, filtering by files can accomplishes the same things, but it's impossible to combine files and types with The docs encourage using
Which encourages the use of types like However, due to:
You can't mix and match Since Rust linting rules change with new versions of cargo (usually released alongside new versions of Rust), this is needed to avoid having to completely devolve into using |
same as #460 (comment) but a little extra flavor on |
I'd like to humbly ask that you reconsider this. How is this different than
Do you mean it shouldn't feel wrong? If it should feel wrong, isn't that an argument to add support for more common well-known types? |
it's different because the file is
no it should not -- this is not how pre-commit is designed to work.
nope |
Introduce dedicated types for rust-toolchain and rust-toolchain.toml files. Cargo linting rules can change with the rust version, so it's helpful to match against the rust-toolchain files as a trigger for Rust linting hooks.