New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for more precise percentage changes #97

Merged

rschristian merged 2 commits into preactjs:master from mister-ben:feat-percent

Apr 22, 2024

Contributor

mister-ben commented Aug 3, 2023

Adds a percent-decimal-places option to set the precision used for percentages in the markdown table, for a better overview of small changes, e.g. +63 B (+0.10%) if set to 2.

Default value is 0, i.e the current behaviour.

mister-ben and others added 2 commits

July 11, 2023 00:16


          feat: Add support for more precise percentage changes

42d3f5d


          refactor: Hold off on making it a new option

1cacfe9

rschristian force-pushed the feat-percent branch from 0cf02c4 to 1cacfe9 Compare

April 22, 2024 22:24

rschristian approved these changes

View reviewed changes

Member

rschristian left a comment

Sorry for the long delay here, I really like this change! However, I thought we could skip making it a configurable option for now -- if it's really needed, it can always be added in later. More precise percentages (IMO) are a better default.

rschristian merged commit f2cd878 into preactjs:master

2 checks passed

renovate bot referenced this pull request in SAP/ui5-webcomponents-react


          chore(deps): update preactjs/compressed-size-action action to v2.6.0 (#…

5acb2e9

…5748)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[preactjs/compressed-size-action](https://togithub.com/preactjs/compressed-size-action)
| action | minor | `2.5.0` -> `2.6.0` |

---

### Release Notes

<details>
<summary>preactjs/compressed-size-action
(preactjs/compressed-size-action)</summary>

###
[`v2.6.0`](https://togithub.com/preactjs/compressed-size-action/releases/tag/2.6.0)

[Compare
Source](https://togithub.com/preactjs/compressed-size-action/compare/2.5.0...2.6.0)

#### New Features / Improvements

- \[feature] Add install script inputs by
[@&#8203;jeffreys-cat](https://togithub.com/jeffreys-cat) in
[https://github.com/preactjs/compressed-size-action/pull/85](https://togithub.com/preactjs/compressed-size-action/pull/85)
- feat: Add support for more precise percentage changes by
[@&#8203;mister-ben](https://togithub.com/mister-ben) in
[https://github.com/preactjs/compressed-size-action/pull/97](https://togithub.com/preactjs/compressed-size-action/pull/97)
- Add support for Bun by
[@&#8203;jack-weilage](https://togithub.com/jack-weilage) in
[https://github.com/preactjs/compressed-size-action/pull/104](https://togithub.com/preactjs/compressed-size-action/pull/104)

#### Action Maintenance

- Update action.yml to use node16 by
[@&#8203;estherkim](https://togithub.com/estherkim) in
[https://github.com/preactjs/compressed-size-action/pull/87](https://togithub.com/preactjs/compressed-size-action/pull/87)
- Move to node20, release v3 by
[@&#8203;jonny-puma](https://togithub.com/jonny-puma) in
[https://github.com/preactjs/compressed-size-action/pull/103](https://togithub.com/preactjs/compressed-size-action/pull/103)

#### Repo Maintenance

- Fix typo by [@&#8203;denniskigen](https://togithub.com/denniskigen) in
[https://github.com/preactjs/compressed-size-action/pull/86](https://togithub.com/preactjs/compressed-size-action/pull/86)
- chore: Update Github actions to latest versions by
[@&#8203;mmckenziedev](https://togithub.com/mmckenziedev) in
[https://github.com/preactjs/compressed-size-action/pull/90](https://togithub.com/preactjs/compressed-size-action/pull/90)
- chore: Bump package-lock.json by
[@&#8203;rschristian](https://togithub.com/rschristian) in
[https://github.com/preactjs/compressed-size-action/pull/105](https://togithub.com/preactjs/compressed-size-action/pull/105)

#### New Contributors

- [@&#8203;denniskigen](https://togithub.com/denniskigen) made their
first contribution in
[https://github.com/preactjs/compressed-size-action/pull/86](https://togithub.com/preactjs/compressed-size-action/pull/86)
- [@&#8203;estherkim](https://togithub.com/estherkim) made their first
contribution in
[https://github.com/preactjs/compressed-size-action/pull/87](https://togithub.com/preactjs/compressed-size-action/pull/87)
- [@&#8203;mmckenziedev](https://togithub.com/mmckenziedev) made their
first contribution in
[https://github.com/preactjs/compressed-size-action/pull/90](https://togithub.com/preactjs/compressed-size-action/pull/90)
- [@&#8203;jack-weilage](https://togithub.com/jack-weilage) made their
first contribution in
[https://github.com/preactjs/compressed-size-action/pull/104](https://togithub.com/preactjs/compressed-size-action/pull/104)
- [@&#8203;jonny-puma](https://togithub.com/jonny-puma) made their first
contribution in
[https://github.com/preactjs/compressed-size-action/pull/103](https://togithub.com/preactjs/compressed-size-action/pull/103)
- [@&#8203;mister-ben](https://togithub.com/mister-ben) made their first
contribution in
[https://github.com/preactjs/compressed-size-action/pull/97](https://togithub.com/preactjs/compressed-size-action/pull/97)
- [@&#8203;jeffreys-cat](https://togithub.com/jeffreys-cat) made their
first contribution in
[https://github.com/preactjs/compressed-size-action/pull/85](https://togithub.com/preactjs/compressed-size-action/pull/85)
- [@&#8203;rschristian](https://togithub.com/rschristian) made their
first contribution in
[https://github.com/preactjs/compressed-size-action/pull/105](https://togithub.com/preactjs/compressed-size-action/pull/105)

**Full Changelog**:
preactjs/compressed-size-action@2.5.0...2.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/SAP/ui5-webcomponents-react).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

sarayourfriend pushed a commit to sarayourfriend/compressed-size-action that referenced this pull request


          feat: Show more precise percentage changes (preactjs#97)

40a4d31

* feat: Add support for more precise percentage changes

* refactor: Hold off on making it a new option

---------

Co-authored-by: Ryan Christian <rchristian@ryanchristian.dev>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet