Merge branch 'master' into legacy-bundles-regenerator

preactjs · Nov 22, 2021 · dcf6a21 · dcf6a21
2 parents 10e234e + 9039ba2
commit dcf6a21
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 32 deletions.
diff --git a/.changeset/seven-lions-cough.md b/.changeset/seven-lions-cough.md
@@ -0,0 +1,5 @@
+---
+'preact-cli': patch
+---
+
+Fixing legacy SW generation while ESM is enabled
diff --git a/.changeset/sixty-badgers-dance.md b/.changeset/sixty-badgers-dance.md
@@ -0,0 +1,5 @@
+---
+'preact-cli': patch
+---
+
+Corrects error when `src/sw.js` does not exist and esm is disabled
diff --git a/packages/cli/lib/lib/webpack/webpack-client-config.js b/packages/cli/lib/lib/webpack/webpack-client-config.js
@@ -46,36 +46,34 @@ async function clientConfig(env) {
 		} else {
 			warn(`Could not find sw.js in ${src}. Using the default service worker.`);
 		}
-		swInjectManifest = env.esm
-			? [
-					new InjectManifest({
-						swSrc: swPath,
-						swDest: 'sw-esm.js',
-						include: [
-							/200\.html$/,
-							/\.esm.js$/,
-							/\.css$/,
-							/\.(png|jpg|svg|gif|webp)$/,
-						],
-						webpackCompilationPlugins: [
-							new webpack.DefinePlugin({
-								'process.env.ESM': true,
-							}),
-						],
-					}),
-			  ]
-			: [
-					new InjectManifest({
-						swSrc: join(src, 'sw.js'),
-						include: [
-							/200\.html$/,
-							/\.js$/,
-							/\.css$/,
-							/\.(png|jpg|svg|gif|webp)$/,
-						],
-						exclude: [/\.esm\.js$/],
-					}),
-			  ];
+
+		if (env.esm) {
+			swInjectManifest.push(
+				new InjectManifest({
+					swSrc: swPath,
+					swDest: 'sw-esm.js',
+					include: [
+						/200\.html$/,
+						/\.esm.js$/,
+						/\.css$/,
+						/\.(png|jpg|svg|gif|webp)$/,
+					],
+					webpackCompilationPlugins: [
+						new webpack.DefinePlugin({
+							'process.env.ESM': true,
+						}),
+					],
+				})
+			);
+		}
+
+		swInjectManifest.push(
+			new InjectManifest({
+				swSrc: swPath,
+				include: [/200\.html$/, /\.js$/, /\.css$/, /\.(png|jpg|svg|gif|webp)$/],
+				exclude: [/\.esm\.js$/],
+			})
+		);
 	}
 
 	let copyPatterns = [

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -127,7 +127,7 @@
     "stack-trace": "0.0.10",
     "style-loader": "^2.0.0",
     "terser-webpack-plugin": "^4.2.3",
-    "typescript": "^4.2.4",
+    "typescript": "~4.2.4",
     "update-notifier": "^5.1.0",
     "url-loader": "^4.1.1",
     "validate-npm-package-name": "^3.0.0",

diff --git a/yarn.lock b/yarn.lock
@@ -14431,7 +14431,7 @@ typedarray@^0.0.6:
   resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
-typescript@^4.2.4:
+typescript@~4.2.4:
   version "4.2.4"
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.2.4.tgz#8610b59747de028fda898a8aef0e103f156d0961"
   integrity sha512-V+evlYHZnQkaz8TRBuxTA92yZBPotr5H+WhQ7bD3hZUndx5tGOa1fuCgeSjxAzM1RiN5IzvadIXTVefuuwZCRg==