Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix
Did you add tests for your changes?
meta
Summary
The tests are scaffolding the
default
template which relies onpreact-cli@2.x
, which requires that there be a.babelrc
file to handleNODE_ENV
-dependentmodules
formatting.The current
preact-cli/babel
(and #639) will respond to atest
environment automatically, so there'll be no need to ship a.babelrc
file.The
Cannot find module "preact-cli/babel"
was thrown in testing because we use--cwd
while building the test directories (for performance / to avoidnpm install
xN). When this happens, dependency lookups are done from the root directory.Well, the root directory doesn't have
preact-cli
asdevDependency
... only the test directory does. Because of that, the process can't find a module named"preact-cli"
; let alone a entry file within it.Does this PR introduce a breaking change?
No