Skip to content

Commit

Permalink
fix(tests): tsc checks js code in toolchain - this fix can't be check…
Browse files Browse the repository at this point in the history
…ed yet without incurring additional runtime cost
  • Loading branch information
Katja Potensky committed Aug 21, 2024
1 parent 2a467a3 commit 5ca6c52
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/diff/props.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ export function setProperty(dom, name, value, oldValue, namespace) {
name != 'colSpan' &&
name != 'role' &&
name != 'popover' &&
// observedAttributes can exist as a static property on custom elements
// a runtime check here has no tangible benefit apart from satisfying typescript
// which runs later in the toolchain
// @ts-ignore
!dom.constructor.observedAttributes?.includes(name) &&
name in dom
) {
Expand Down

0 comments on commit 5ca6c52

Please sign in to comment.