Extract into separate func

preactjs · Oct 12, 2024 · e109c40 · e109c40
1 parent 5e04644
commit e109c40
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/benches/src/02_replace1k.html b/benches/src/02_replace1k.html
@@ -35,7 +35,7 @@
 				const elementSelector = 'tr:first-child > td:first-child';
 
 				// MUST BE KEPT IN SYNC WITH WARMUP COUNT IN benches/scripts/config.js
-				const WARMUP_COUNT = 25;
+				const WARMUP_COUNT = 5;
 				for (let i = 0; i < WARMUP_COUNT; i++) {
 					markRunStart(`warmup-${i}`);
 					run();

diff --git a/src/diff/index.js b/src/diff/index.js
@@ -509,12 +509,10 @@ function diffElementNodes(
 				}
 
 				// @ts-expect-error
-				dom.textContent = newChildren;
+				dom.textContent = text;
 			}
 		} else {
 			if (oldHtml) dom.innerHTML = '';
-			// Previous render was a single text child. New children are not so let's
-			// unmount the previous text child
 			if (typeof oldProps.children === 'string') {
 				dom.removeChild(dom.firstChild);
 			}