Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the new benchmarks repo and update #4310

Merged
merged 21 commits into from
Mar 29, 2024
Merged

Conversation

andrewiggins
Copy link
Member

This PR integrates the preactjs/benchmarks repo as a git submodule for us to run locally.

I added some instructions for setting up the submodule in the CONTRIBUTING file, but they can probably be expanded.

@coveralls
Copy link

coveralls commented Mar 18, 2024

Coverage Status

coverage: 99.601%. remained the same
when pulling 21f018b on benchmarks-repo
into d3d57db on main.

Copy link

github-actions bot commented Mar 19, 2024

Size Change: 0 B

Total Size: 60.3 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4.05 kB 0 B
compat/dist/compat.module.js 3.98 kB 0 B
compat/dist/compat.umd.js 4.11 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
dist/preact.js 4.55 kB 0 B
dist/preact.min.js 4.59 kB 0 B
dist/preact.min.module.js 4.59 kB 0 B
dist/preact.min.umd.js 4.62 kB 0 B
dist/preact.module.js 4.57 kB 0 B
dist/preact.umd.js 4.63 kB 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@preactjs preactjs deleted a comment from github-actions bot Mar 28, 2024
@preactjs preactjs deleted a comment from github-actions bot Mar 28, 2024
@preactjs preactjs deleted a comment from github-actions bot Mar 28, 2024
Copy link

github-actions bot commented Mar 28, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +2% (-6.25ms - +13.90ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +0% (-0.31ms - +0.04ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +0% (-2.39ms - +0.28ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +4% (-0.33ms - +0.59ms)
    preact-local vs preact-main
  • replace1k: slower ❌ 0% - 4% (0.04ms - 2.40ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +4% (-0.07ms - +0.07ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.31ms - +0.39ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +3% (-1.40ms - +1.02ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local898.45ms - 915.00ms-unsure 🔍
-1% - +2%
-6.25ms - +13.90ms
preact-main897.16ms - 908.65msunsure 🔍
-2% - +1%
-13.90ms - +6.25ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local26.79ms - 26.79ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main26.79ms - 26.79msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.57ms - 16.67ms-unsure 🔍
-2% - +0%
-0.31ms - +0.04ms
preact-main16.58ms - 16.92msunsure 🔍
-0% - +2%
-0.04ms - +0.31ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.63ms - 1.63ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.63ms - 1.63msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local71.79ms - 72.18ms-unsure 🔍
-3% - +0%
-2.39ms - +0.28ms
preact-main71.72ms - 74.35msunsure 🔍
-0% - +3%
-0.28ms - +2.39ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.47ms - 6.47ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main6.47ms - 6.47msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.30ms - 17.06ms-unsure 🔍
-2% - +4%
-0.33ms - +0.59ms
preact-main16.30ms - 16.82msunsure 🔍
-3% - +2%
-0.59ms - +0.33ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.73ms - 4.74ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main4.73ms - 4.74msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local66.68ms - 68.74ms-slower ❌
0% - 4%
0.04ms - 2.40ms
preact-main65.92ms - 67.06msfaster ✔
0% - 4%
0.04ms - 2.40ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.66ms - 3.68ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main3.66ms - 3.68msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local27.65ms - 28.50ms-unsure 🔍
-2% - +2%
-0.66ms - +0.56ms
preact-main27.68ms - 28.56msunsure 🔍
-2% - +2%
-0.56ms - +0.66ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local34.83ms - 36.67ms-unsure 🔍
-2% - +5%
-0.68ms - +1.87ms
preact-main34.28ms - 36.03msunsure 🔍
-5% - +2%
-1.87ms - +0.68ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local24.67ms - 25.22ms-unsure 🔍
-1% - +2%
-0.23ms - +0.49ms
preact-main24.57ms - 25.05msunsure 🔍
-2% - +1%
-0.49ms - +0.23ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local22.89ms - 23.91ms-unsure 🔍
-4% - +2%
-0.84ms - +0.50ms
preact-main23.14ms - 24.01msunsure 🔍
-2% - +4%
-0.50ms - +0.84ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local28.00ms - 29.51ms-unsure 🔍
-4% - +3%
-1.01ms - +0.99ms
preact-main28.12ms - 29.42msunsure 🔍
-3% - +4%
-0.99ms - +1.01ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.84ms - 22.83ms-unsure 🔍
-1% - +5%
-0.15ms - +1.04ms
preact-main21.56ms - 22.21msunsure 🔍
-5% - +1%
-1.04ms - +0.15ms
-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.59ms - 1.69ms-unsure 🔍
-4% - +4%
-0.07ms - +0.07ms
preact-main1.59ms - 1.69msunsure 🔍
-4% - +4%
-0.07ms - +0.07ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.01ms - 1.02ms-unsure 🔍
-1% - +1%
-0.01ms - +0.01ms
preact-main1.01ms - 1.02msunsure 🔍
-1% - +1%
-0.01ms - +0.01ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local26.29ms - 26.74ms-unsure 🔍
-1% - +1%
-0.31ms - +0.39ms
preact-main26.21ms - 26.74msunsure 🔍
-1% - +1%
-0.39ms - +0.31ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.13ms - 1.13ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.13ms - 1.13msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.46ms - 34.07ms-unsure 🔍
-4% - +3%
-1.40ms - +1.02ms
preact-main32.55ms - 34.36msunsure 🔍
-3% - +4%
-1.02ms - +1.40ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.59ms - 3.61ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main3.59ms - 3.61msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-

tachometer-reporter-action v2 for Benchmarks

@andrewiggins andrewiggins merged commit 757746a into main Mar 29, 2024
2 checks passed
@andrewiggins andrewiggins deleted the benchmarks-repo branch March 29, 2024 00:15
@JoviDeCroock JoviDeCroock mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants