Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import renderToPipeableStream in server.mjs for re-exporting #4440

Merged

Conversation

3846masa
Copy link
Contributor

@3846masa 3846masa commented Jul 9, 2024

Describe the bug

In Preact v10.22.1, renderToPipeableStream is re-exported from server.mjs.

However, the export { ... } from '...' ; syntax does not define a renderToPipeableStream variable, so the export default { renderToPipeableStream } part will cause an error.

This PR solves the above problem by explicitly importing renderToPipeableStream.

Code that reproduces the bug

https://gist.github.com/3846masa/bb3ade18b8a16d947f85920640ab35a2

@coveralls
Copy link

Coverage Status

coverage: 99.612%. remained the same
when pulling b75edab on 3846masa-tmp:fix/export-render-to-pipeable-stream
into 212b1f6 on preactjs:main.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@rschristian rschristian merged commit f7f9d9b into preactjs:main Jul 9, 2024
2 checks passed
@JoviDeCroock JoviDeCroock mentioned this pull request Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants