-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Warn on NaN in dep arrays instead of throwing #4527
Conversation
7ede1a2
to
85a3024
Compare
Size Change: +6 B (+0.01%) Total Size: 62.1 kB
ℹ️ View Unchanged
|
85a3024
to
65563e4
Compare
28bac68
to
88e74bd
Compare
workflow: build-test.yml | ||
workflow: ci.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI should now be completely on track again.
Sorry the recent changes had so many issues, the fact that our setup runs both the PR & main workflows (as they exist on both branches) simultaneously made this a bit weird to figure out all the details on.
Closes: #4344
It'll fix the issue of debug throwing & killing the app, but whether or not this works correctly is still very usage-dependent.
Will depend on #4528, as our benchmarks require a successful asset upload from
main
to be able to run, and its CI currently fails.