Revert unkeyed no-search #4604
Merged
Revert unkeyed no-search #4604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
JoviDeCroock
commented
Dec 11, 2024
| @@ -1830,6 +1830,44 @@ describe('render()', () => { | |||
| expect(scratch.textContent).to.equal('A'); | |||
| }); | |||
|
|
|||
| // #2949 | |||
| it.skip('should not swap unkeyed chlildren', () => { | |||
There was a problem hiding this comment.
Added a test highlighting the issue
|
Size Change: -68 B (-0.11%) Total Size: 62.3 kB
ℹ️ View Unchanged
|
rschristian
approved these changes
Dec 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4550
This revert isn't necessarily needed but after a lot of investigation we do increase components remounting a lot, to avoid people having to deal with a breaking change like that I'd like to propose a revert here.
If people fall into this issue, please use
keyto avoid elements being reused when you don't want to.