convert bidders: adgeneration

prebid · May 18, 2022 · 0170539 · 0170539
1 parent f849022
commit 0170539
Show file tree

Hide file tree

Showing 9 changed files with 55 additions and 52 deletions.
diff --git a/modules/adbookpspBidAdapter.js b/modules/adbookpspBidAdapter.js
@@ -123,9 +123,9 @@ function buildRequest(validBidRequests, bidderRequest) {
     id: bidderRequest.bidderRequestId,
     tmax: bidderRequest.timeout,
     site: {
-      domain: window.location.hostname,
-      page: window.location.href,
-      ref: bidderRequest.refererInfo.referer,
+      domain: bidderRequest.refererInfo.domain,
+      page: bidderRequest.refererInfo.page,
+      ref: bidderRequest.refererInfo.ref,
     },
     source: buildSource(validBidRequests, bidderRequest),
     device: buildDevice(),

diff --git a/modules/addefendBidAdapter.js b/modules/addefendBidAdapter.js
@@ -21,7 +21,8 @@ export const spec = {
       pageId: false,
       gdpr_applies: bidderRequest.gdprConsent && bidderRequest.gdprConsent.gdprApplies ? bidderRequest.gdprConsent.gdprApplies : 'true',
       gdpr_consent: bidderRequest.gdprConsent && bidderRequest.gdprConsent.consentString ? bidderRequest.gdprConsent.consentString : '',
-      referer: bidderRequest.refererInfo.referer,
+      // TODO: is 'page' the correct item here?
+      referer: bidderRequest.refererInfo.page,
       bids: [],
     };
 

diff --git a/modules/adfBidAdapter.js b/modules/adfBidAdapter.js
@@ -81,7 +81,7 @@ export const spec = {
       }
 
       if (!site.page) {
-        site.page = bidderRequest.refererInfo.referer;
+        site.page = bidderRequest.refererInfo.page;
       }
     }
 

diff --git a/modules/adgenerationBidAdapter.js b/modules/adgenerationBidAdapter.js
@@ -49,7 +49,8 @@ export const spec = {
       if (!validReq.mediaTypes || !validReq.mediaTypes.native) {
         data = tryAppendQueryString(data, 'imark', '1');
       }
-      data = tryAppendQueryString(data, 'tp', bidderRequest.refererInfo.referer);
+      // TODO: is 'page' the right value here?
+      data = tryAppendQueryString(data, 'tp', bidderRequest.refererInfo.page);
       if (isIos()) {
         const hyperId = getHyperId(validReq);
         if (hyperId != null) {

diff --git a/test/spec/modules/adagioBidAdapter_spec.js b/test/spec/modules/adagioBidAdapter_spec.js
@@ -16,7 +16,6 @@ import { loadExternalScript } from '../../../src/adloader.js';
 import * as utils from '../../../src/utils.js';
 import { config } from '../../../src/config.js';
 import { NATIVE } from '../../../src/mediaTypes.js';
-import * as prebidGlobal from 'src/prebidGlobal.js';
 import { executeRenderer } from '../../../src/Renderer.js';
 
 const BidRequestBuilder = function BidRequestBuilder(options) {

diff --git a/test/spec/modules/adbookpspBidAdapter_spec.js b/test/spec/modules/adbookpspBidAdapter_spec.js
@@ -951,7 +951,9 @@ const bidderRequest = {
   bidderRequestId: '999ccceeee11',
   timeout: 200,
   refererInfo: {
-    referer: 'http://example-domain.com/foo',
+    page: 'http://mock-page.com',
+    domain: 'mock-page.com',
+    ref: 'http://example-domain.com/foo',
   },
   gdprConsent: {
     gdprApplies: 1,
@@ -999,8 +1001,8 @@ const bannerExchangeRequest = {
     },
   },
   site: {
-    domain: location.hostname,
-    page: location.href,
+    domain: 'mock-page.com',
+    page: 'http://mock-page.com',
     ref: 'http://example-domain.com/foo',
   },
   source: {
@@ -1089,8 +1091,8 @@ const videoExchangeRequest = {
     },
   },
   site: {
-    domain: location.hostname,
-    page: location.href,
+    domain: 'mock-page.com',
+    page: 'http://mock-page.com',
     ref: 'http://example-domain.com/foo',
   },
   source: {
@@ -1171,8 +1173,8 @@ const mixedExchangeRequest = {
     },
   },
   site: {
-    domain: location.hostname,
-    page: location.href,
+    domain: 'mock-page.com',
+    page: 'http://mock-page.com',
     ref: 'http://example-domain.com/foo',
   },
   source: {

diff --git a/test/spec/modules/addefendBidAdapter_spec.js b/test/spec/modules/addefendBidAdapter_spec.js
@@ -25,7 +25,7 @@ describe('addefendBidAdapter', () => {
     return spec.buildRequests(buildRequest, {
       ...bidderRequest || {},
       refererInfo: {
-        referer: 'https://referer.example.com'
+        page: 'https://referer.example.com'
       }
     })[0];
   };

diff --git a/test/spec/modules/adfBidAdapter_spec.js b/test/spec/modules/adfBidAdapter_spec.js
diff --git a/test/spec/modules/adgenerationBidAdapter_spec.js b/test/spec/modules/adgenerationBidAdapter_spec.js
@@ -105,7 +105,7 @@ describe('AdgenerationAdapter', function () {
     ];
     const bidderRequest = {
       refererInfo: {
-        referer: 'https://example.com'
+        page: 'https://example.com'
       }
     };
     const data = {