GumGum: uses encodeURIComponent inline (#5124)

* uses encodeURIComponent inline * adds test for jcsi param
prebid · Apr 17, 2020 · 250dd1d · 250dd1d
1 parent a213fa0
commit 250dd1d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/modules/gumgumBidAdapter.js b/modules/gumgumBidAdapter.js
@@ -60,7 +60,7 @@ function _getBrowserParams(topWindowUrl) {
     pu: topUrl,
     ce: storage.cookiesAreEnabled(),
     dpr: topWindow.devicePixelRatio || 1,
-    jcsi: JSON.stringify({ t: 0, rq: 8 }),
+    jcsi: encodeURIComponent(JSON.stringify({ t: 0, rq: 8 })),
     ogu: getOgURL()
   }
 

diff --git a/test/spec/modules/gumgumBidAdapter_spec.js b/test/spec/modules/gumgumBidAdapter_spec.js
@@ -228,6 +228,13 @@ describe('gumgumAdapter', function () {
         expect(bidRequest.data).to.not.include.any.keys('ns');
       }
     });
+    it('has jcsi param correctly encoded', function () {
+      const jcsi = JSON.stringify({ t: 0, rq: 8 });
+      const encodedJCSI = encodeURIComponent(jcsi);
+      const bidRequest = spec.buildRequests(bidRequests)[0];
+      expect(bidRequest.data.jcsi).to.not.contain(/\{.*\}/);
+      expect(bidRequest.data.jcsi).to.eq(encodedJCSI);
+    });
   })
 
   describe('interpretResponse', function () {